[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt PATCH 1/7] util: alloc: Remove VIR_ALLOC_QUIET



On Thu, 2020-09-10 at 12:36 +0100, Daniel P. Berrangé wrote:
> On Thu, Sep 10, 2020 at 01:29:19PM +0200, Tim Wiederhake wrote:
> > Signed-off-by: Tim Wiederhake <twiederh redhat com>
> > ---
> >  src/rpc/virnetmessage.c |  2 +-
> >  src/util/viralloc.h     | 14 --------------
> >  src/util/virbitmap.c    |  2 +-
> >  src/util/virerror.c     |  6 +++---
> >  src/util/virlog.c       |  2 +-
> >  src/util/virthread.c    |  2 +-
> >  tests/virpcimock.c      |  6 +++---
> >  7 files changed, 10 insertions(+), 24 deletions(-)
> > 
> > diff --git a/src/rpc/virnetmessage.c b/src/rpc/virnetmessage.c
> > index c4ddafc01d..011b32b100 100644
> > --- a/src/rpc/virnetmessage.c
> > +++ b/src/rpc/virnetmessage.c
> > @@ -539,7 +539,7 @@ void
> > virNetMessageSaveError(virNetMessageErrorPtr rerr)
> >      } else {
> >          rerr->code = VIR_ERR_INTERNAL_ERROR;
> >          rerr->domain = VIR_FROM_RPC;
> > -        if (VIR_ALLOC_QUIET(rerr->message) == 0)
> > +        if (VIR_ALLOC(rerr->message) == 0)
> 
> We didn't want to be doing such conversions. We kept VIR_ALLOC_QUIET
> as an alias for VIR_ALLOC, because the intent was to convert straight
> to g_new0, and not have this intermediate step.

Thanks for the input! I will split the series and rework the "alias
removal" part.

Tim
> 
> Regards,
> Daniel


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]