[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 02/12] qemu: Return perf status that affect next boot for shutoff domains



On a Friday in 2020, Lin Ma wrote:
While we set up perf events for a shutoff domain and check the settings,
All of perf events are reported as 'disabled', unless we add --config,
This is redundant for a shutoff domain.

# virsh domstate $GUEST
shut off

# virsh perf --domain $GUEST
cmt            : disabled
mbmt           : disabled
mbml           : disabled
......

# virsh perf --domain $GUEST --enable mbmt
mbmt           : enabled

# virsh perf --domain $GUEST
cmt            : disabled
mbmt           : disabled
mbml           : disabled
......

Use virDomainObjGetOneDefState instead of virDomainObjGetOneDef to fix
the issue. After patch, The perf event status of a shutoff domain is
reported correctly:

# virsh domstate $GUEST
shut off

# virsh perf --domain $GUEST
cmt            : disabled
mbmt           : disabled
mbml           : disabled
......

# virsh perf --domain $GUEST --enable mbmt
mbmt           : enabled

# virsh perf --domain $GUEST
cmt            : disabled
mbmt           : enabled
mbml           : disabled
......

Signed-off-by: Lin Ma <lma suse de>
---
src/qemu/qemu_driver.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)


Reviewed-by: Ján Tomko <jtomko redhat com>

Jano

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]