[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 4/5] node_device: detect DASD devices



...
> > >       }
> > > +    /* dasd disk */
> > > +    if (STRPREFIX(def->caps->data.storage.block, "/dev/dasd")) {
> > > +        def->caps->data.storage.drive_type = g_strdup("dasd");
> > > +        VIR_DEBUG("Found storage type '%s' for device "
> > > +                  "with sysfs path '%s'",
> > > +                  def->caps->data.storage.drive_type,
> > > +                  def->sysfs_path);
> >
> > I understand why we would need it for /dev/vdX, but can udev not know the
> > drive_type from kernel? IOW Do we really need ^this hunk?
> >
>
> For DASDs there are currently no identifies in udev besides ID_PATH.
> ID_TYPE=disk does not exist. That's why the DASDs fall through the
> udevProcessStorage detection logic. Without this hunk the dasd devices are
> being detected as storage devices but than end up as "Unsupported storage
> type".
> The short answer is yes. :-)

Okay, can you put a concise version of ^this in a commentary then?

Erik


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]