[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt PATCH v2 1/7] tests: Fix false positive in testConfRoundTrip.



testConfRoundTrip would return 0 (success) if virConfWriteMem returned 0 (nothing
written) and virTestCompareToFile failed.

Signed-off-by: Tim Wiederhake <twiederh redhat com>
---
 tests/virconftest.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/virconftest.c b/tests/virconftest.c
index ab29b5b712..cac3718495 100644
--- a/tests/virconftest.c
+++ b/tests/virconftest.c
@@ -51,8 +51,7 @@ static int testConfRoundTrip(const void *opaque)
         fprintf(stderr, "Failed to process %s\n", srcfile);
         goto cleanup;
     }
-    ret = virConfWriteMem(buffer, &len, conf);
-    if (ret < 0) {
+    if (virConfWriteMem(buffer, &len, conf) < 0) {
         fprintf(stderr, "Failed to serialize %s back\n", srcfile);
         goto cleanup;
     }
-- 
2.26.2


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]