[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 09/17] qemu: domain: Fill in (i)SCSI backend nodename if it is not present in status XML



On a Friday in 2020, Peter Krempa wrote:
For upgrade reasons so that we can modify the used nodename we must
generate the old version for all status XMLs which don't have it stored
explicitly.

The change will be required as using the user-provided alias may result
in too-long nodenames which will be rejected by qemu.

Add code which fills in the appropriate old value and add test cases to
validate that it's added and also that existing nodenames are not
overwritten.

Signed-off-by: Peter Krempa <pkrempa redhat com>
---
src/qemu/qemu_domain.c                      | 55 +++++++++++++++++++++
tests/qemustatusxml2xmldata/modern-in.xml   |  1 +
tests/qemustatusxml2xmldata/upgrade-in.xml  |  1 +
tests/qemustatusxml2xmldata/upgrade-out.xml | 12 +++++
4 files changed, 69 insertions(+)


Reviewed-by: Ján Tomko <jtomko redhat com>

Jano

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]