[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 16/17] qemuDomainPrepareHostdev: Don't base backend nodename on device alias



On a Friday in 2020, Peter Krempa wrote:
QEMU's blockdev nodenames which are used to back SCSI/iSCSI hostdevs are
limited to 32 characters. If a user passes a very long user alias as
name of the host device it's easy to end up with a too-long nodename.

To prevent this from happening don't base the nodename on the possibly
user-specified alias but on the normal sequential node name generator.

We then store the name in the status XML for further use.

Signed-off-by: Peter Krempa <pkrempa redhat com>
---
src/qemu/qemu_domain.c                        |  3 +-
.../hostdev-scsi-lsi.x86_64-latest.args       | 38 ++++++++-----------
...ostdev-scsi-virtio-scsi.x86_64-latest.args | 36 +++++++++---------
3 files changed, 36 insertions(+), 41 deletions(-)


Reviewed-by: Ján Tomko <jtomko redhat com>

Jano

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]