[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] libxl: use b_info->{acpi,acpi} when available



On 9/10/20 6:18 AM, Marek Marczykowski-Górecki wrote:
b_info->u.hvm.{acpi,apic} are deprecated. But also, on recent libxl
version (4.14) the old one seems to be broken. While libxl part should
be fixed too, update the usage here and at some point drop support for
the old version.
b_info->acpi was added in Xen 4.8
b_info->apic was added in Xen 4.10
Xen 4.10 is the oldest version that still has security support (until
December 2020).

Signed-off-by: Marek Marczykowski-Górecki <marmarek invisiblethingslab com>
---
  src/libxl/libxl_conf.c                              | 13 +++++++++++++
  tests/libxlxml2domconfigdata/basic-hvm.json         |  4 ++--
  tests/libxlxml2domconfigdata/cpu-shares-hvm.json    |  4 ++--
  .../libxlxml2domconfigdata/fullvirt-acpi-slic.json  |  4 ++--
  .../fullvirt-cpuid-legacy-nest.json                 |  4 ++--
  tests/libxlxml2domconfigdata/fullvirt-cpuid.json    |  4 ++--
  .../max-eventchannels-hvm.json                      |  4 ++--
  tests/libxlxml2domconfigdata/max-gntframes-hvm.json |  4 ++--
  tests/libxlxml2domconfigdata/moredevs-hvm.json      |  4 ++--
  .../libxlxml2domconfigdata/variable-clock-hvm.json  |  4 ++--
  .../vnuma-hvm-legacy-nest.json                      |  4 ++--
  tests/libxlxml2domconfigdata/vnuma-hvm.json         |  4 ++--
  12 files changed, 35 insertions(+), 22 deletions(-)

This looks good to me.

Reviewed-by: Michal Privoznik <mprivozn redhat com>

I'll wait a bit with pushing it though in case Jim wants to chime in.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]