[libvirt] [PATCH v2 4/4] network: Check for active network during networkGetDHCPLeases

[Michal Privoznik]

On 9/16/20 2:18 PM, Ján Tomko wrote:
> On a Wednesday in 2020, Michal Privoznik wrote:
>> On 9/16/20 9:17 AM, morecache at gmail.com wrote:
>>> From: Lin Ma <lma at suse.de>
>>>
>>> It doesn't make sense querying dhcp leases for interfaces against an 
>>> inactive
>>> network, This patch adds a check to see if the network is active.
>>>
> 
> NACK, see discussion on v1.
> 
> https://www.redhat.com/archives/libvir-list/2020-September/msg00673.html
> 

So what if I set up a static lease in network XM, start the network, 
then shut it down and change the XML? Wouldn't I get a different lease 
until the network is started again?

The NSS plugin suffers from the same problem, btw. But it can't know 
whether the network is still running or not (if we don't want it to do 
some hacks).

Michal