[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt PATCH v2 4/4] storage: add support for qcow2 LUKS encryption



Coverity was unhappy....

On 9/17/20 7:59 AM, Daniel P. Berrangé wrote:
> The storage driver was wired up to support creating raw volumes in LUKS
> format, but was never adapted to support LUKS-in-qcow2. This is trivial
> as it merely requires the encryption properties to be prefixed with
> the "encrypt." prefix, and "encrypt.format=luks" when creating the
> volume.
> 
> Signed-off-by: Daniel P. Berrangé <berrange redhat com>

[...]

> diff --git a/src/util/virqemu.h b/src/util/virqemu.h
> index b1296cb657..be14c04d51 100644
> --- a/src/util/virqemu.h
> +++ b/src/util/virqemu.h
> @@ -60,6 +60,7 @@ char *virQEMUBuildDriveCommandlineFromJSON(virJSONValuePtr src);
>  
>  void virQEMUBuildBufferEscapeComma(virBufferPtr buf, const char *str);
>  void virQEMUBuildQemuImgKeySecretOpts(virBufferPtr buf,
> +                                      int format,
>                                        virStorageEncryptionInfoDefPtr enc,
>                                        const char *alias)
>      ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3);

New argument (2) is an int, so (2) and (3) have to change...

John
[...]


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]