[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH v6 3/3] bhyve: soften requirements for slot 1



On Sun, Sep 20, 2020 at 07:21:15PM +0400, Roman Bogorodskiy wrote:
> Currently, slot 1 is only allowed to be used by the LPC device.
> Relax this requirement and allow to use slot 1 if it was explicitly
> specified by the user for any other device type. In this case the LPC
> device will have the next available address.
> 
> If slot 1 was not used by the user, it'll be reserved for the LPC
> device, even if it is not configured to make address assignment
> consistent in case the LPC device becomes necessary (e.g. the user
> adds a console or a video device which require LPC).
> 
> Signed-off-by: Roman Bogorodskiy <bogorodskiy gmail com>
> ---
>  po/POTFILES.in                                |  1 -
>  src/bhyve/bhyve_device.c                      | 50 +++++++++----------
>  ...argv-addr-non-isa-controller-on-slot-1.xml |  1 +
>  tests/bhyvexml2argvtest.c                     |  2 +-
>  4 files changed, 25 insertions(+), 29 deletions(-)

We're missing the bhyvexml2argv-addr-non-isa-controller-on-slot-1.args
file from the commit, so this breaks CI. I presume you forgot to commit
it from your local checkout.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]