[libvirt PATCH 3/5] rpc: socket: properly call virSetCloseExec
Ján Tomko
jtomko at redhat.com
Tue Sep 22 21:32:31 UTC 2020
cppcheck reports:
style: Argument 'fd<0' to function virSetCloseExec is always 0 [knownArgument]
Signed-off-by: Ján Tomko <jtomko at redhat.com>
Fixes: 4b9919af4024a6fbc3d4ee996d8a4c27dbc44285
---
src/rpc/virnetsocket.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c
index ebdeadc4a0..f79a638775 100644
--- a/src/rpc/virnetsocket.c
+++ b/src/rpc/virnetsocket.c
@@ -1388,7 +1388,7 @@ int virNetSocketDupFD(virNetSocketPtr sock, bool cloexec)
}
#ifndef F_DUPFD_CLOEXEC
if (cloexec &&
- virSetCloseExec(fd < 0)) {
+ virSetCloseExec(fd) < 0) {
int saveerr = errno;
closesocket(fd);
errno = saveerr;
--
2.26.2
More information about the libvir-list
mailing list