[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt PATCH 0/9] [GSoC]: Libvirt driver for Jailhouse



On Thu, Sep 17, 2020 at 04:23:50PM +0100, Daniel P. Berrangé wrote:
> I'm sending this series on behalf of Prakhar Bansal who has been unable
> to sucessfully send the whole series. GMail is blocking sending of
> certain patches for unknown reasons.
> 
>   https://www.redhat.com/archives/libvir-list/2020-September/msg00309.html
> 
> It is also available at
> 
>   https://github.com/pbansal2/libvirt/tree/jailhouse_driver

I've had a look through the patches, and given some comments. Overall
the driver looks like a pretty good initial effort. Most of the comments
are more on the style / codiing patterns side.

> 
> Prakhar Bansal (9):
>   Jailhouse driver: first commit with skeleton code
>   Jailhouse driver: Implementation of ConnectOpen
>   Jailhouse driver: Implementation of ConnectGetType
>   Jailhouse driver: Implementation of DomainCreate* callbacks
>   Jailhouse driver: Implementation of DomainInfo/State/List
>   Jailhouse driver: Implementation of DomainLookup* callbacks
>   Jailhouse driver: Implementation of DomainShutdown/Destroy callbacks
>   Jailhouse driver: Fixes for creation of cells, fetching cell info,
>     disabling jailhouse hypervisor
>   Jailhouse driver: Add events to events queue in
>     DomainCreate/Shutdown/Destroy
> 
>  include/libvirt/virterror.h          |   1 +
>  libvirt.spec.in                      |   7 +
>  m4/virt-driver-jailhouse.m4          |  42 ++
>  meson.build                          |   4 +
>  meson_options.txt                    |   1 +
>  po/POTFILES.in                       |   2 +
>  src/conf/domain_conf.c               |   1 +
>  src/conf/domain_conf.h               |   1 +
>  src/jailhouse/Makefile.inc.am        |  47 ++
>  src/jailhouse/jailhouse.conf         |  10 +
>  src/jailhouse/jailhouse_api.c        | 458 +++++++++++++++
>  src/jailhouse/jailhouse_api.h        | 103 ++++
>  src/jailhouse/jailhouse_driver.c     | 837 +++++++++++++++++++++++++++
>  src/jailhouse/jailhouse_driver.h     |  82 +++
>  src/jailhouse/libvirtd_jailhouse.aug |  43 ++
>  src/jailhouse/meson.build            |  49 ++
>  src/meson.build                      |   1 +
>  src/qemu/qemu_command.c              |   1 +
>  src/remote/remote_daemon.c           |   4 +
>  src/remote/remote_daemon_dispatch.c  |   3 +-
>  src/util/virerror.c                  |   1 +
>  21 files changed, 1697 insertions(+), 1 deletion(-)
>  create mode 100644 m4/virt-driver-jailhouse.m4
>  create mode 100644 src/jailhouse/Makefile.inc.am
>  create mode 100644 src/jailhouse/jailhouse.conf
>  create mode 100644 src/jailhouse/jailhouse_api.c
>  create mode 100644 src/jailhouse/jailhouse_api.h
>  create mode 100644 src/jailhouse/jailhouse_driver.c
>  create mode 100644 src/jailhouse/jailhouse_driver.h
>  create mode 100644 src/jailhouse/libvirtd_jailhouse.aug
>  create mode 100644 src/jailhouse/meson.build
> 
> -- 
> 2.26.2
> 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]