[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[PATCH 1/6] qemu: snapshot: Rename 'qemuSnapshotCreateDiskActive' to 'qemuSnapshotCreateActiveExternalDisks'



Be more specific about the role of the function. It's creating the disk
portion of an external active snapshot.

Signed-off-by: Peter Krempa <pkrempa redhat com>
---
 src/qemu/qemu_snapshot.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c
index 48a4e9dd41..0435d4c371 100644
--- a/src/qemu/qemu_snapshot.c
+++ b/src/qemu/qemu_snapshot.c
@@ -1151,13 +1151,13 @@ qemuSnapshotDiskUpdateSource(virQEMUDriverPtr driver,

 /* The domain is expected to be locked and active. */
 static int
-qemuSnapshotCreateDiskActive(virQEMUDriverPtr driver,
-                             virDomainObjPtr vm,
-                             virDomainMomentObjPtr snap,
-                             virHashTablePtr blockNamedNodeData,
-                             unsigned int flags,
-                             virQEMUDriverConfigPtr cfg,
-                             qemuDomainAsyncJob asyncJob)
+qemuSnapshotCreateActiveExternalDisks(virQEMUDriverPtr driver,
+                                      virDomainObjPtr vm,
+                                      virDomainMomentObjPtr snap,
+                                      virHashTablePtr blockNamedNodeData,
+                                      unsigned int flags,
+                                      virQEMUDriverConfigPtr cfg,
+                                      qemuDomainAsyncJob asyncJob)
 {
     qemuDomainObjPrivatePtr priv = vm->privateData;
     g_autoptr(virJSONValue) actions = NULL;
@@ -1346,9 +1346,9 @@ qemuSnapshotCreateActiveExternal(virQEMUDriverPtr driver,

     /* the domain is now paused if a memory snapshot was requested */

-    if ((ret = qemuSnapshotCreateDiskActive(driver, vm, snap,
-                                            blockNamedNodeData, flags, cfg,
-                                            QEMU_ASYNC_JOB_SNAPSHOT)) < 0)
+    if ((ret = qemuSnapshotCreateActiveExternalDisks(driver, vm, snap,
+                                                     blockNamedNodeData, flags, cfg,
+                                                     QEMU_ASYNC_JOB_SNAPSHOT)) < 0)
         goto cleanup;

     /* the snapshot is complete now */
-- 
2.26.2


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]