[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt PATCH 4/9] schema: Add schema for guest or host cpu definition



On Mon, Sep 21, 2020 at 15:07:27 +0200, Tim Wiederhake wrote:

This doesn't mention what it will be used for ...

> Signed-off-by: Tim Wiederhake <twiederh redhat com>
> ---
>  docs/schemas/cpu.rng     | 12 ++++++++++++
>  docs/schemas/meson.build |  1 +
>  2 files changed, 13 insertions(+)
>  create mode 100644 docs/schemas/cpu.rng
> 
> diff --git a/docs/schemas/cpu.rng b/docs/schemas/cpu.rng
> new file mode 100644
> index 0000000000..d1eb67430d
> --- /dev/null
> +++ b/docs/schemas/cpu.rng
> @@ -0,0 +1,12 @@
> +<?xml version="1.0"?>
> +<grammar xmlns="http://relaxng.org/ns/structure/1.0"; datatypeLibrary="http://www.w3.org/2001/XMLSchema-datatypes";>
> +  <include href="basictypes.rng"/>
> +  <include href="cputypes.rng"/>

... and it isn't obvious from the impl.

> +
> +  <start>
> +    <choice>
> +      <ref name="guestcpu"/>
> +      <ref name="hostcpu"/>
> +    </choice>
> +  </start>
> +</grammar>

You can use:

Reviewed-by: Peter Krempa <pkrempa redhat com>

after you properly justify the changes since they are not
self-explanatory.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]