[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt PATCH 6/9] cpu: Validate XML



On Wed, Sep 30, 2020 at 13:54:41 +0200, Tim Wiederhake wrote:
> On Tue, 2020-09-29 at 11:12 +0200, Peter Krempa wrote:
> > (...)
> > 
> > > diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c
> > > index dea950ce68..40d8da4a8e 100644
> > > --- a/src/conf/cpu_conf.c
> > > +++ b/src/conf/cpu_conf.c
> > > @@ -20,9 +20,11 @@
> > >  
> > >  #include <config.h>
> > >  
> > > +#include "configmake.h"
> > 
> > This is suspicious. Why did you add this line?
> 
> PKGDATADIR is defined there and used in the call to virFileFindResource
> in virCPUDefParseXML to locate the schema.

Ah, right, please do mention that in the commit message as it seems to
be an unrelated change.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]