[PATCH 05/37] virDomainNetDefParseXML: Separate and localize parsing of 'backend/@vhost'

Ján Tomko jtomko at redhat.com
Wed Sep 21 13:44:29 UTC 2022


On a Monday in 2022, Peter Krempa wrote:
>Move it into an independent block and move temporary variables locally.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/conf/domain_conf.c | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
>@@ -9484,7 +9479,14 @@ virDomainNetDefParseXML(virDomainXMLOption *xmlopt,
>                                          &def->driver.virtio.guest.ufo) < 0)
>                 return NULL;
>         }
>-        def->backend.vhost = g_steal_pointer(&vhost_path);
>+    }
>+
>+    if (def->type != VIR_DOMAIN_NET_TYPE_HOSTDEV &&
>+        virDomainNetIsVirtioModel(def)) {
>+        g_autofree  char *vhost = virXPathString("string(./backend/@vhost)", ctxt);
>+

Double space -------^

>+        if (vhost)
>+            def->backend.vhost = virFileSanitizePath(vhost);
>     }
>
>     def->linkstate = VIR_DOMAIN_NET_INTERFACE_LINK_STATE_DEFAULT;
>-- 
>2.37.1
>


More information about the libvir-list mailing list