[PATCH libvirt v1 0/3] Ensure full early console access with libvirt

[Michal Prívozník]

On 9/28/23 17:37, Marc Hartmayer wrote:
> Currently, early console output may be lost, e.g. if starting a guest with
> `virsh start --console` guest, which can make debugging of early failures very
> difficult
> (like zipl messages or disabled wait conditions happening early). This is
> because QEMU may emit serial console output before the libvirt console client
> starts to consume data from the pts. This can be prevented by starting the guest
> in paused state, connect to the console and then resume the guest.
> 
> Note: There is still a problem in QEMU itself, see QEMU patch series `[PATCH]
> chardev/char-pty: Avoid losing bytes when the other side just (re-)connected`
> [1]
> 
> Changelog:
> RFCv1->v1:
> + rebased on current master
> + worked in comments from Daniel
> 
> [1] https://lists.gnu.org/archive/html/qemu-devel/2023-08/msg02725.html
> 
> Marc Hartmayer (3):
>   virsh: add `console --resume` support
>   Improve `virsh start --console` behavior
>   Improve `virsh create --console` behavior
> 
>  tools/virsh-console.c |  8 ++++
>  tools/virsh-console.h |  1 +
>  tools/virsh-domain.c  | 94 ++++++++++++++++++++++++++++++++-----------
>  3 files changed, 80 insertions(+), 23 deletions(-)
> 
> 
> base-commit: dd403f8873cf8de7675b89ed757a4228af7bc05e

All 'issues' I've raised are trivial. I've fixed them and pushed. Sorry
for leaving this to rot this long on the list.

Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

Michal