[Libvirt-cim] [PATCH 3 of 6] Add VirtualSystemMigrationService

Dan Smith danms at us.ibm.com
Tue Dec 4 01:57:32 UTC 2007


KR> I think to mean:
KR>     if (dconn == NULL)

I think to mean that too :)

KR> I'm unsure why you call CMSetStatus() before calling
KR> virDomainMigrate().  If virDomainMigrate() fails, we set a failure
KR> status.  Otherwise, we set the status again below.  Although,
KR> setting it here is harmless anyway. =)

Heh, oops.  The reason is that when I was first working on it, the
whole migrate function was just setting status to OK, which I
apparently never removed.

I've got a new version of this cooked up with more function anyway,
I'll make these changes and send it out tomorrow.

Thanks :)

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms at us.ibm.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvirt-cim/attachments/20071203/f08defbb/attachment.sig>


More information about the Libvirt-cim mailing list