[Libvirt-cim] [PATCH] SDS: Fixed segfaulting reference(Names) call due to missing assoc_classname

Jay Gagnon grendel at linux.vnet.ibm.com
Thu Dec 6 16:54:29 UTC 2007


Heidi Eckhart wrote:
> # HG changeset patch
> # User Heidi Eckhart <heidieck at linux.vnet.ibm.com>
> # Date 1196935598 -3600
> # Node ID ba4bc35f508573c53e4303ce2e7a9b5299b95f38
> # Parent  618509ea5c6089678975cde7f4b5a687aa1e68f0
> SDS: Fixed segfaulting reference(Names) call due to missing assoc_classname
> Signed-off-by: Heidi Eckhart <heidieck at linux.vnet.ibm.com>
>
> diff -r 618509ea5c60 -r ba4bc35f5085 src/Virt_SettingsDefineState.c
> --- a/src/Virt_SettingsDefineState.c	Thu Dec 06 11:06:38 2007 +0100
> +++ b/src/Virt_SettingsDefineState.c	Thu Dec 06 11:06:38 2007 +0100
> @@ -365,6 +365,8 @@ static struct std_assoc _vs_to_vssd = {
>          .target_class = (char**)&virtual_system_setting_data,
>          .target_prop = "SettingData",
>
> +        .assoc_class = (char**)&assoc_classname,
> +
>          .handler = vs_to_vssd,
>          .make_ref = make_ref
>  };
> @@ -375,6 +377,8 @@ static struct std_assoc _vssd_to_vs = {
>
>          .target_class = (char**)&computer_system,
>          .target_prop = "ManagedElement",
> +
> +        .assoc_class = (char**)&assoc_classname,
>
>          .handler = vssd_to_vs,
>          .make_ref = make_ref
>
>
>   
Well, we certainly don't want segfaults.  Nice catch. +1


-- 

-Jay




More information about the Libvirt-cim mailing list