[Libvirt-cim] [PATCH]

Jay Gagnon grendel at linux.vnet.ibm.com
Thu Dec 13 15:13:42 UTC 2007


Kaitlin Rupert wrote:
> # HG changeset patch
> # User Kaitlin Rupert <karupert at us.ibm.com>
> # Date 1197410852 28800
> # Node ID 8761c7b39ea87feb54f89e41e1a7044104ec9399
> # Parent  6c3ca59055416d7bb07716d3a750800e6087878e
> #2 GetInstance() does not return an instance that matches the instanceID given.
>
> Updates - removed boolean and now use a string, get instanceID in GetInstance() call instead.
>
> Add a argument to return_ele_cap() that handles the GetInstance().  If this argument is set, get the InstanceID from the ref.  In the loop that walks through the domains on the system, check to see if this id matches one of the names returned.  If there is a match, create the instance and then exit from the loop.
>
> If no match is found, an error is returned.
>
> Failing query:
> wbemcli gi http://localhost:5988/root/virt:Xen_EnabledLogicalElementCapabilities.InstanceID="kaitlin_test"
>
> localhost:5988/root/virt:Xen_EnabledLogicalElementCapabilities.InstanceID="kaitlin_test" Caption,Description,InstanceID="hd_domain",ElementName,ElementNameEditSupported=FALSE,MaxElementNameLen,RequestedStatesSupported=2,3,9,10,11,ElementNameMask,StateAwareness,CreationClassName="Xen_EnabledLogicalElementCapabilities"
>
> Signed-off-by: Kaitlin Rupert <karupert at us.ibm.com>
>
>   

Good patch and all, but it looks like something about your commit
message is making it treat the "#2 GetInstance()..." as a comment, hence
the blank subject line.

Ah.  I just looked back at our other "#foo" patches, and it looks like
they have all been patchsets or [RFC] type patches, so no actual patch
(until this one) has had its commit message start with the pound sign. 
I guess we'll have to revise the guidelines a little.  Any suggestions?

-- 

-Jay




More information about the Libvirt-cim mailing list