[Libvirt-cim] [PATCH] Fix externally-visible name of type_from_classname()

Heidi Eckhart heidieck at linux.vnet.ibm.com
Fri Nov 2 09:52:48 UTC 2007


Dan Smith wrote:
> @@ -458,8 +458,11 @@ static CMPIStatus get_device(const CMPIO
>          CMPIStatus s;
>          virConnectPtr conn;
>          CMPIInstance *inst;
> +        const char *cn;
>
> -        conn = connect_by_classname(_BROKER, CLASSNAME(reference), &s);
> +        cn = CLASSNAME(reference);
> +
> +        conn = connect_by_classname(_BROKER, cn, &s);
>   
What is your intention by breaking this one-liner into three lines ?
>          if (!conn)
>                  return s;
>   
I had problems to apply this patch to the latest version from the 
external libvirt-cim repository. But I checked it and all changes have 
been applied.
Works for me ... +1 (tested on KVM)

-- 
Regards

Heidi Eckhart
Software Engineer
Linux Technology Center - Open Hypervisor

heidieck at linux.vnet.ibm.com

**************************************************
IBM Deutschland Entwicklung GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschaeftsfuehrung: Herbert Kircher
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294




More information about the Libvirt-cim mailing list