[Libvirt-cim] [PATCH] Make HostedResourcePool a little more discerning

Dan Smith danms at us.ibm.com
Thu Nov 8 22:10:29 UTC 2007


KR> Patch looks good, but wouldn't you also want to do this check for
KR> the sys_to_pool side of things as well?

I'm not sure what you mean, this change *was* to sys_to_pool() :)

KR> Or, basically, for any of the API calls that take a properties
KR> argument?

That brings up a good point, being that we might fail the test
improperly if they specified (and we start honoring) the properties
filter, so maybe we need to allow for passing a list of properties
that are *excluded* from the list of properties checked.  Since this
is only comparing key properties, is it valid to use the property
filter to exclude key properties?  I could see the policy being either
way really.

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms at us.ibm.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvirt-cim/attachments/20071108/11be8e6e/attachment.sig>


More information about the Libvirt-cim mailing list