[Libvirt-cim] [PATCH 1 of 5] Add new HostedService association provider

Dan Smith danms at us.ibm.com
Fri Nov 9 01:22:53 UTC 2007


KR> +static CMPIStatus host_to_service(const CMPIObjectPath *ref,
KR> +                                  struct std_assoc_info *info,
KR> +                                  struct inst_list *list)
KR> +{
KR> +        CMPIStatus s = {CMPI_RC_OK, NULL};
KR> +        CMPIInstance *inst;
KR> +
KR> +        s = rpcs_instance(ref, &inst, _BROKER);
KR> +        if (s.rc != CMPI_RC_OK)
KR> +                return s;
KR> +        if (!CMIsNullObject(inst))
KR> +                inst_list_add(list, inst);
KR> +
KR> +        s = get_vsms(ref, &inst, _BROKER, 0);

Hmm, I didn't notice in the earlier patch (since it was just a
unstaticification of an existing function) but the fourth parameter to
get_vsms() isn't used for anything, so we should remove it.

Looks good other than that.  I'll apply and cook up a patch to remove
the extraneous parameter.

Thanks!

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms at us.ibm.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvirt-cim/attachments/20071108/087f43e8/attachment.sig>


More information about the Libvirt-cim mailing list