[Libvirt-cim] [PATCH 03 of 12] Make ElementAllocatedFromPool use connect_by_classname()

Dan Smith danms at us.ibm.com
Mon Nov 19 19:30:45 UTC 2007


KR> This is terribly nit-picky.. but why use variables for ns and cn?
KR> They only get used once in this function, right?  I suppose it
KR> does look cleaner though.

It is just to clean up the function calls.  Also, in lots of these
functions, there are already lines that depend on something like 'ns'
being passed in, so just setting ns to what it was before reduces the
likelihood of breaking something that depends on such semantics.
Given how fast I'm going through these, breaking fewer things is a
good thing, I think.

We do the "const char *ns = NAMESPACE(ref)" thing in lots of other
places and it just "feels right" for some reason, but if people
disagree and want to set a policy about it, that's fine with me.

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms at us.ibm.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvirt-cim/attachments/20071119/0b709d9c/attachment.sig>


More information about the Libvirt-cim mailing list