[Libvirt-cim] [PATCH] Enumeration on HostSystem class is returning dups

[Dan Smith]

HE> # HG changeset patch
HE> # User Heidi Eckhart <heidieck at linux.vnet.ibm.com>
HE> # Date 1195733309 -3600
HE> # Node ID 8c0410bfe3d3da3ef61aa40bfe75f1f23426b77d
HE> # Parent  278c59f67cb1fe0520e8dfa7b118cd907e8f10a1
HE> Enumeration on HostSystem class is returning dups

I think most of the changes in this patch are good, but I'm not quite
sure why they prevent returning dups.  Can you explain a little bit?

HE> + err:
HE> +        virConnectClose(conn);
HE>   out:

virConnectClose(NULL) is a no-op (like free(NULL)).  Everywhere else
in the code, we just have a single out label.  I'd prefer that we
remain consistent with that, unless there is a good reason not to for
a particular instance.

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms at us.ibm.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvirt-cim/attachments/20071126/82e55d0e/attachment.sig>