[Libvirt-cim] [PATCH] Convert CMSetStatusWithChars calls to cu_statusf, clean up

Dan Smith danms at us.ibm.com
Tue Nov 27 21:39:30 UTC 2007


JG> # HG changeset patch
JG> # User Jay Gagnon <grendel at linux.vnet.ibm.com>
JG> # Date 1196197789 18000
JG> # Node ID d798c4c8a940eeb6d24cdb89eb0bf7141c928e19
JG> # Parent  c1c0c6a064474701ec5e743d32819f179553c540
JG> Convert CMSetStatusWithChars calls to cu_statusf, clean up.

Sweet!

JG> -                CMSetStatusWithChars(broker, &s, CMPI_RC_ERR_FAILED,
JG> -                                     "Could not get ResourceType.");
JG> +                cu_statusf(broker, &s, 
JG> +                           CMPI_RC_ERR_FAILED,
JG> +                           "Could not get ResourceType.");

I know that these are pre-existing error messages, but could I
convince you to remove trailing periods from all the error messages?
Not only are they inconsistent with the rest of the code, but rather
unconventional, I'd say.

Looks good otherwise, thanks!

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms at us.ibm.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvirt-cim/attachments/20071127/98cc10ef/attachment.sig>


More information about the Libvirt-cim mailing list