[Libvirt-cim] [PATCH] [TEST] Add -d to duplicate error output to stderr

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Fri Apr 11 01:24:08 UTC 2008


Zhengang Li wrote:
> zli at linux.vnet.ibm.com wrote:
> 
>> @@ -119,6 +125,7 @@ def do_main(types=['Xen'], p=parser):
>>          else:
>>              def do_try():
>>                  try:
>> +                    log_param(options.debug)
> log_param() is invoked here. It doesn't hurt to leave the invoke in 
> every test cases. But we don't have to add that in future test cases.
> 
>>                      from VirtLib.utils import setup_ssh_key
>>                      from XenKvmLib.test_doms import 
>> destroy_and_undefine_all
>>                      setup_ssh_key()
> 
> 

Excellent - do_try() just gets better in my book.  ;)

Would like to see some review comments on this patch.  I have no 
complaints, but I'm interested in hearing whether people think this is 
useful.

Thanks!

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list