[Libvirt-cim] [PATCH] Make TimeoutPeriod optional in RSC method

[Jay Gagnon]

Dan Smith wrote:
> # HG changeset patch
> # User Dan Smith <danms at us.ibm.com>
> # Date 1209492001 25200
> # Node ID 907f388e3a0a456e2a94043556ace4b11589b6cd
> # Parent  a6ad7167443f326ec96e2161127024a86259e4fb
> Make TimeoutPeriod optional in RSC method
> Apparently the CIMOM is allowed to ignore NULL paramters as missing, which
> means we can't tell if it's missing or NULL.  Since NULL is a valid value
> for this parameter, making it optional seems like the only logical choice.
>
> Signed-off-by: Dan Smith <danms at us.ibm.com>
>
> diff -r a6ad7167443f -r 907f388e3a0a src/Virt_ComputerSystem.c
> --- a/src/Virt_ComputerSystem.c	Tue Apr 29 07:05:34 2008 -0700
> +++ b/src/Virt_ComputerSystem.c	Tue Apr 29 11:00:01 2008 -0700
> @@ -862,7 +862,7 @@ static struct method_handler RequestStat
>          .name = "RequestStateChange",
>          .handler = state_change,
>          .args = {{"RequestedState", CMPI_uint16, false},
> -                 {"TimeoutPeriod", CMPI_dateTime, false},
> +                 {"TimeoutPeriod", CMPI_dateTime, true},
>                   ARG_END
>          }
>  };
>
>   

Sounds like the way it's gotta go.  +1

-- 

-Jay