[Libvirt-cim] [PATCH] [TEST] Clean up xmt-makefvt.sh

[Dan Smith]

KR> +        touch /boot/vmlinuz-$DUMMY_PATH
KR> +        mkdir /lib/modules/$DUMMY_PATH
KR> +        image="/boot/vmlinuz-$DUMMY_PATH"

I know I didn't comment on this when the function was added, but I think
this is a bad idea.  I know I've suggested touching a kernelish file in
/boot to fool this script in the past, but this self-hacking behavior
seems like the wrong way to solve this problem.  If the xen kernel
really isn't there, I think our stuff should fake it in the image,
instead of our script faking the system so the other parts of the script
work unmodified.

I think that fooling this and other scripts on the system into thinking
there is a xen kernel image available is a bad precedent to set.

What do you think?

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms at us.ibm.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvirt-cim/attachments/20080826/3e7beb5f/attachment.sig>