[Libvirt-cim] [PATCH] Make sure to set status in eo_parser_xml to avoid crash

Heidi Eckhart heidieck at linux.vnet.ibm.com
Thu Feb 21 13:23:34 UTC 2008


Dan Smith wrote:
> @@ -380,6 +386,10 @@ static CMPIStatus parse_instance(const C
>                                  CU_DEBUG("Unexpected node: %s\n", child->name);
>                  }
>          }
>   
Maybe you can define CMPIStatus s = {CMPI_RC_OK, ""}; instead of setting 
it later. The result would be the same.
> +
> +        cu_statusf(broker, &s,
> +                   CMPI_RC_OK,
> +                   "");
>
>   out:
>          free(class);
>   
Other than that ... makes sense and applies fine ... +1.

-- 
Regards

Heidi Eckhart
Software Engineer
IBM Linux Technology Center - Open Hypervisor




More information about the Libvirt-cim mailing list