[Libvirt-cim] [PATCH] [CU] Add set_int_property() function to EO parse

[Dan Smith]

KR> +                unsigned_val = value;

I think you should cast this explicitly to avoid a warning in the
future.  We have to compile without strict warnings because the
generated parser code is riddled with issues, but I think we should
try to make a routine such as this one as clean as possible.

KR> +                s = CMSetProperty(inst, prop, &(unsigned_val), type);

Don't you want a (CMPIValue *) cast in front of your &(unsigned_val)?

KR> +			EOTRACE("propertyname = %s\n", $1); 
KR> +                        int rc;
KR> +			//uint64_t value = $3;
KR> +                        CMPIType t = set_int_prop($3, $1, *_INSTANCE);

I think you've got some whitespace issues here, and I think we can
remove the commented-out code, right?

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms at us.ibm.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvirt-cim/attachments/20080228/fb1fdb01/attachment.sig>