[Libvirt-cim] [PATCH] HS: returns results for wrong object path
Dan Smith
danms at us.ibm.com
Tue Jan 8 15:04:56 UTC 2008
HE> + if (STREQC(classname, "VirtualSystemManagementService")) {
HE> + s = get_vsms(ref, &inst, _BROKER);
HE> + }
HE> + else if (STREQC(classname, "ResourcePoolConfigurationService")) {
HE> + s = rpcs_instance(ref, &inst, _BROKER);
HE> + }
HE> + else if (STREQC(classname, "VirtualSystemMigrationService")) {
HE> + s = get_migration_service(ref, &inst, _BROKER);
HE> + }
HE> + if (s.rc != CMPI_RC_OK)
HE> + return s;
This doesn't fit the style of the rest of the code. The "else if"
statements should be on the same line as the closing brace, and there
should be a blank line before the second and unrelated if.
Otherwise, a good fix. Thanks!
--
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms at us.ibm.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvirt-cim/attachments/20080108/8db1f3d4/attachment.sig>
More information about the Libvirt-cim
mailing list