[Libvirt-cim] [PATCH] Remove the embedded object parsing pieces from VirtualSystemManagmentService

[Heidi Eckhart]

Kaitlin Rupert wrote:
> @@ -467,10 +431,8 @@ static CMPIStatus define_system(CMPIMeth
>          CMPIInstance *vssd;
>          CMPIInstance *sys;
>          CMPIObjectPath *sys_op;
>   
"sys_op" seem to be no longer needed
>   
> @@ -1027,9 +981,7 @@ static CMPIStatus update_resource_settin
>                  goto out;
>          }
>
> -        parse_str_inst_array(arr, NAMESPACE(ref), &list);
> -
> -        s = _update_resource_settings(ref, &list, func);
> +        s = _update_resource_settings(ref, arr, func);
>
>   out:
>          inst_list_free(&list);
>   
"list" seem to be no longer needed
> @@ -1040,7 +992,7 @@ static CMPIStatus rasd_refs_to_insts(con
>  static CMPIStatus rasd_refs_to_insts(const CMPIContext *ctx,
>                                       const CMPIObjectPath *reference,
>                                       CMPIArray *arr,
> -                                     struct inst_list *list)
> +                                     CMPIArray **out_arr)
>  {
>          CMPIStatus s;
>          int i;
> @@ -1049,6 +1001,11 @@ static CMPIStatus rasd_refs_to_insts(con
>          c = CMGetArrayCount(arr, &s);
>          if (s.rc != CMPI_RC_OK)
>                  return s;
> +
> +        *out_arr = CMNewArray(_BROKER,
> +                              c,
> +                              CMPI_instance,
> +                              &s); 
>   
It might be nice to use a CMPIArray *ret_arr (or something like that) 
instead of *out_arr.
>  static struct method_handler DefineSystem = {
>          .name = "DefineSystem",
>          .handler = define_system,
> -        .args = {{"SystemSettings", CMPI_string},
> -                 {"ResourceSettings", CMPI_stringA},
> +        .args = {{"SystemSettings", CMPI_instance},
> +                 {"ResourceSettings", CMPI_instanceA},
>                   {"ReferencedConfiguration", CMPI_string},
>   
I know its not one of your changes but the cim 2.16 mof talks about 
"ReferenceConfiguration" not "Referenced...". Please can you also update 
this ? Thanks.

Besides these little things, this patch makes the VSMS provider clearer 
and better to read. Excellent job.

-- 
Regards

Heidi Eckhart
Software Engineer
IBM Linux Technology Center - Open Hypervisor