[Libvirt-cim] [PATCH] [TEST] #3 Update VSSDC.01 for KVM/XenFV/LXC support

[Kaitlin Rupert]

> @@ -85,32 +84,13 @@
>                   rlist[2] : "%s/%s" % (test_dom, test_mac),
>                   rlist[3] : "%s/%s" % (test_dom, "proc")
>                  }
> +    if virt == 'LXC':
> +        rlist = [get_typed_class(virt, 'MemResourceAllocationSettingData')]
> +        prop_list = {rlist[0] : "%s/%s" % (test_dom, "mem")}        

I missed this last time, but you can use rlist[1] since you already know 
rlist[1] = get_typed_class(virt, 'MemResourceAllocationSettingData').

You can then remove the rlist = [get_typed_class(virt, 
'MemResourceAllocationSettingData')] line.

> +def assoc_values(ip, assoc_info, cn, an, vssd):
>      """

Can you change the comment of this function?  It mentions verifying 
specific properties.  Instead, it verifies all of the values of the 
instance.

> -
> +        status = compare_all_prop(assoc_info[0], vssd)
> +        return status

Instead of returning here, can you check the status?  If status != PASS, 
print a log message and return the status.  That way it's clear why the 
test fails.

>      except  Exception, detail :
>          logger.error("Exception in assoc_values function: %s" % detail)
>          return FAIL 
> @@ -143,49 +116,53 @@
>      status = FAIL

Otherwise, looks good.  Thanks!


-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com