[Libvirt-cim] [PATCH] [TEST] #3 Fix CS 22 to use providers instead of virsh

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Tue Jul 22 15:33:21 UTC 2008


>> -            status = PASS
>> +            status = chk_state(test_dom, options.ip, DEFINE_STATE, 
>> options.virt)
>> +            if status != PASS:
>> +                logger.error("%s not in defined state as expected." % 
>> test_dom)
>>   
> The log message is misleading. It gives me a feeling that domgst is not 
> in defined state and it is expected state for the domgst.
> Can we chop off the "as expected" part?
> or have log stmt something like "%s should have been in defined state" ??

Sure, I'll change it to "%s should have been in defined state" - this 
log message is more clear.

Thanks!

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list