[Libvirt-cim] [PATCH 3 of 6] 1) Added support for KVM

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Wed Jul 30 15:35:31 UTC 2008


> -    # undefine the vs
> -    undefine_test_domain(default_dom, options.ip, options.virt)
> +    if status != PASS:
> +        destroy_netpool(server, virt, test_network)
> +        destroy_and_undefine_domain(default_dom, server, virt)
> +        return status
> +
> +    # try to suspend already suspended VS
> +    rq_state = SUSPND_STATE
> +    status = try_request_state_change(default_dom, server,
> +                                      rq_state, TIME, err_no, 
> +                                      err_desc, virt)

I'm not sure I see the benefit of this change.  You're not verifying the 
state of the guest.

It's possible for RequestStateChange() to return a success and for the 
guest to be in an unexpected state.

> +
> +    destroy_netpool(server, virt, test_network)
> +    destroy_and_undefine_domain(default_dom, server, virt)
> 
>      return status

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list