[Libvirt-cim] [PATCH 5 of 6] 1) Added support for KVM

Deepti B Kalakeri deeptik at linux.vnet.ibm.com
Thu Jul 31 08:17:31 UTC 2008



Kaitlin Rupert wrote:
>
>> - # undefine the vs
>> - undefine_test_domain(default_dom, options.ip, options.virt)
>> + if status != PASS:
>> + destroy_netpool(server, virt, test_network)
>> + destroy_and_undefine_domain(default_dom, server, virt)
>> + return status
>>
>> + # Try to reboot the VS which is suspened
>> + rq_state = REBOOT_STATE + status = 
>> try_request_state_change(default_dom, server,
>> + rq_state, TIME, err_no,
>> + err_desc, virt)
>> +
>
> Also here, you don't verify the guest has been rebooted properly. Is 
> there a reason to pull this piece out of the loop?
The test case returns an exception when we try to reboot VS when it is 
in suspended state.
The part of the code in the loop which we execute is not suppose to 
return any exception. Hence the code in the loop and the one in 
try_request_state_change() cannot be combined together.
Regarding validating the req_state value after 
try_request_state_change() can be done to make sure the state still 
remains the same as it was in before calling the RequestStateChange().

Thanks and Regards,
Deepti.
>
> Kaitlin Rupert
> IBM Linux Technology Center
> kaitlin at linux.vnet.ibm.com
>
> _______________________________________________
> Libvirt-cim mailing list
> Libvirt-cim at redhat.com
> https://www.redhat.com/mailman/listinfo/libvirt-cim




More information about the Libvirt-cim mailing list