[Libvirt-cim] [PATCH] [TEST] Update SystemDevice.01~03 for LXC support

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Tue Jun 3 16:01:19 UTC 2008


> diff -r 351d11163eaa -r 37c9c0b22ced suites/libvirt-cim/cimtest/SystemDevice/01_forward.py
> --- a/suites/libvirt-cim/cimtest/SystemDevice/01_forward.py	Fri May 30 10:47:26 2008 +0800
> +++ b/suites/libvirt-cim/cimtest/SystemDevice/01_forward.py	Tue Jun 03 14:12:25 2008 +0800
> @@ -33,7 +33,7 @@
>  from CimTest.Globals import logger, do_main
>  from CimTest.ReturnCodes import PASS, FAIL
> 
> -sup_types = ['Xen', 'KVM', 'XenFV']
> +sup_types = ['Xen', 'KVM', 'XenFV', 'LXC']
> 
>  test_dom = "test_domain"
>  test_mac = "00:11:22:33:44:55"
> @@ -50,7 +50,10 @@
> 
>      status = PASS
>      virt_xml = vxml.get_class(options.virt)
> -    cxml = virt_xml(test_dom, vcpus = test_cpu, mac = test_mac, disk = test_disk)
> +    if options.virt == "LXC":
> +        cxml = virt_xml(test_dom, vcpus = test_cpu)

For LXC, it would make more sense to define a guest with memory.  You 
can specify the <vcpu> tag when you create a container, however, the tag 
is currently ignored.

The container's XML will preserve the <memory> tag, but the value isn't 
being used for anything at the moment.  But this value should be used in 
the future.

> diff -r 351d11163eaa -r 37c9c0b22ced suites/libvirt-cim/cimtest/SystemDevice/03_fwderrs.py
> --- a/suites/libvirt-cim/cimtest/SystemDevice/03_fwderrs.py	Fri May 30 10:47:26 2008 +0800
> +++ b/suites/libvirt-cim/cimtest/SystemDevice/03_fwderrs.py	Tue Jun 03 14:12:25 2008 +0800
> @@ -40,7 +40,7 @@
>  from CimTest import Globals
>  from CimTest.ReturnCodes import PASS, FAIL, XFAIL_RC
> 
> -sup_types = ['Xen', 'KVM', 'XenFV']
> +sup_types = ['Xen', 'KVM', 'XenFV', 'LXC']
> 
>  test_dom = "virt1"
>  test_mac = "00:11:22:33:44:55"
> @@ -64,15 +64,19 @@
> 
>      status = PASS
>      virt_xml = vxml.get_class(options.virt)
> -    cxml = virt_xml(test_dom, vcpus = test_cpu, mac = test_mac,
> -                    disk = test_disk)
> +    if options.virt == "LXC":
> +        cxml = virt_xml(test_dom, vcpus = test_cpu)
> +        devlist = [ "Memory" ]

Same here - this vcpu value will be ignored when the container is created.

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list