[Libvirt-cim] [PATCH] [TEST] Modifying devices.py to fix tc 01_netport.py which was failing on F9 libvirt-cim rpm

Deepti B Kalakeri deeptik at linux.vnet.ibm.com
Fri Jun 20 05:45:17 UTC 2008



Kaitlin Rupert wrote:
>> from XenKvmLib.classes import get_typed_class
>>
>> -LinkTechnology_Ethernet = 2
>> +net_rev = 598
>> +
>> +# The branch has to be removed once the new rpm
>> +# including the changes in revision 598 is available.
>> +# The value of LinkTechnology should be set to 2 for
>> +# network, bridge and ethernet type interfaces.
>> +if net_rev > CIM_REV:
>> + LinkTechnology_Ethernet = 0
>
> This change occurred due to changeset 599. I know this is a minor 
> change, but can you change this yo be net_rev >= CIM_REV and use 599 
> as the changeset number.
>
> When I looked at rev 598, I was confused that it didn't have anything 
> to do with network interfaces, so using 599 is a little clearer I think.
Sorry, I just used someother no other than the changeset present in the 
patch.
yeah it shld be 599 instead of 598 and the patch which I was referring 
is "Fix setting of the proper CIM network type for network devices".

Modified this and submitted the patch.

Thanks and Regards,
Deepti.




More information about the Libvirt-cim mailing list