[Libvirt-cim] [PATCH] Fix potiential seg fault in VSMigrationService.c

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Wed Jun 25 20:02:57 UTC 2008


# HG changeset patch
# User Kaitlin Rupert <karupert at us.ibm.com>
# Date 1214422449 25200
# Node ID edf96787c23dc7a91a008916b4b00b22fc22703a
# Parent  7a00ccfafc36a62f506543c2d767ba667db404e7
Fix potiential seg fault in VSMigrationService.c

This seg fault can happen if the system does not have Pegasus configured for repositoryIsDefaultInstanceProvider=true.

Signed-off-by: Kaitlin Rupert <karupert at us.ibm.com>

diff -r 7a00ccfafc36 -r edf96787c23d src/Virt_VSMigrationService.c
--- a/src/Virt_VSMigrationService.c	Mon Jun 23 15:13:56 2008 -0700
+++ b/src/Virt_VSMigrationService.c	Wed Jun 25 12:34:09 2008 -0700
@@ -1248,11 +1248,12 @@
                  CMGetCharPtr(CMObjectPathToString(*job_op, NULL)));
 
         *job_op = CBCreateInstance(_BROKER, context, *job_op, jobinst, &s);
-        CMSetNameSpace(*job_op, job->ref_ns);
         if ((s.rc != CMPI_RC_OK) || (CMIsNullObject(*job_op))) {
                 CU_DEBUG("Failed to create job instance: %i", s.rc);
                 goto out;
         }
+
+        CMSetNameSpace(*job_op, job->ref_ns);
 
  out:
         return s;




More information about the Libvirt-cim mailing list