[Libvirt-cim] [PATCH 1 of 6] ComputerSystem: enhance enum functionality for use in assocs
Heidi Eckhart
heidieck at linux.vnet.ibm.com
Tue Mar 4 08:36:02 UTC 2008
Dan Smith wrote:
> JG> if (s.rc != CMPI_RC_OK) {
> JG> virDomainFree(list[i]);
> JG> continue;
> JG> }
>
> JG> should achieve the same functionality but in what I would call a much
> JG> cleaner way. Everyone, feel free to chime in here one way or the
> JG> other.
>
> That's a valid point, although I would rather have one cleanup path to
> avoid leaks in the future. Why not just have the conditional be
> (s.rc == CMPI_RC_OK) and do the add there?
>
> Anyway, it's minor so I've applied this patch set.
>
>
Fine - for me both points are valid and I will take care of them in the
future and apply where necessary and as possible :).
--
Regards
Heidi Eckhart
Software Engineer
IBM Linux Technology Center - Open Hypervisor
More information about the Libvirt-cim
mailing list