[Libvirt-cim] [PATCH] [TEST] Fixing the tc which failed bcs of the vxml.py and const.py changes for KVM

[Kaitlin Rupert]

  > diff -r ec679dca161f -r 6a273db93afc 
suites/libvirt-cim/cimtest/NetworkPort/01_netport.py
> --- a/suites/libvirt-cim/cimtest/NetworkPort/01_netport.py	Tue May 27 03:25:54 2008 -0700
> +++ b/suites/libvirt-cim/cimtest/NetworkPort/01_netport.py	Tue May 27 04:14:04 2008 -0700
> @@ -39,11 +39,13 @@ from CimTest.Globals import logger
>  from CimTest.Globals import logger
>  from CimTest.Globals import do_main
>  from CimTest.ReturnCodes import PASS, FAIL, XFAIL_RC
> +from XenKvmLib import const
> 
>  sup_types = ['Xen', 'KVM', 'XenFV']
> 
>  test_dom = "test_domain"
>  test_mac = "00:11:22:33:44:55"
> +const.KVM_default_net_type='bridge'
> 
>  @do_main(sup_types)
>  def main():

> diff -r ec679dca161f -r 6a273db93afc suites/libvirt-cim/cimtest/ResourceAllocationFromPool/05_RAPF_err.py
> --- a/suites/libvirt-cim/cimtest/ResourceAllocationFromPool/05_RAPF_err.py	Tue May 27 03:25:54 2008 -0700
> +++ b/suites/libvirt-cim/cimtest/ResourceAllocationFromPool/05_RAPF_err.py	Tue May 27 04:14:04 2008 -0700
> @@ -55,10 +55,12 @@ from CimTest.Globals import do_main, pla
>  from CimTest.Globals import do_main, platform_sup
>  from XenKvmLib.vxml import get_class
>  from XenKvmLib.classes import get_typed_class
> +from XenKvmLib import const
> 
>  test_dom   = "RAPF_domain"
>  test_mac   = "00:11:22:33:44:aa"
>  test_vcpus = 1
> +const.KVM_default_net_type='bridge'

Instead of using the bridge type for these tests, I'd leave them as 
network type tests.  In the future, instead of using virsh to create 
guests, we should be using DefineSystem() because DefineSystem() creates 
a guest through the provider.

I'd create a specific test that specifies the bridge type (or you can 
use NetworkPort/03_user_netport.py. whichever).  A customer might have 
some existing guests that will need to be managed.  However, additional 
guests will be created using DefineSystem(), so I'd suggest using making 
the bridge network type a special case.

For that test, instead of setting the value of 
const.KVM_default_net_type, I'd modify the KVMXML init function so that 
it takes a network type.

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com