[Libvirt-cim] [PATCH] [TEST] #2 Fix ECTP 01_forward.py to support system with multiple networks defined

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Tue Nov 11 21:44:58 UTC 2008


>>
>>  import sys
>> +from sets import Set
>>   
> We dont require to import Set here.

Oops!  Yes, I was considering using the Set module, but then realized it 
wasn't needed.

>>      prev_namespace = Globals.CIM_NS
>>      Globals.CIM_NS = 'root/interop'
>>
>> -    status = verify_ectp_assoc(server, virt)
>> +    reg_classname = get_typed_class(virt, "RegisteredProfile")
>> +    an = get_typed_class(virt,"ElementConformsToProfile")
>> +
>> +    status, prof_inst_lst = get_proflist(server, reg_classname, virt)
>> +    if status != PASS:
>> +        return status
>>   
> We need to undefine and destroy the domain on FAIL and also the 
> namespace should be set to prev_namespace.
> otherwise the test looks great.

Yes, definitely.  Thanks!

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list