[Libvirt-cim] [PATCH] * Added association Console Redirections Service <-> Console Redirection Service

[Kaitlin Rupert]

Richard Maciel wrote:
> # HG changeset patch
> # User Richard Maciel <richardm at br.ibm.com>
> # Date 1224196932 25200
> # Node ID 7fbd020ca47795c3528a698b3ddccc718cae9f2c
> # Parent  ef98854352d7c0e7abbe2d77ba9d885ef61629e6
> * Added association Console Redirections Service <-> Console Redirection Service
>  Capabilities into the ElementCapabilities.c file
> 
> * Added ConsoleRedirectionServiceCapabilities.h to export the
> get_console_rs_caps function
> * get_console_rs_caps is not static anymore
> 
> Signed-off-by: Richard Maciel <richardm at br.ibm.com>
> 

Hi Richard,

Thanks for the changes.  When you get review comments on a patch, you'll 
want to update the original patch with the changes.  This looks like 
it's a patch on top of the first patch you sent.

You can modify an existing patch using "hg qref".  Also, as a 
convention, we number the updated patches.  So you'll want to use "hg 
qref -e" to update the commit log so that the subject of the patch has a 
(#2) in front.  You'll also want to update the commit log so that is 
lists what changes were made.

I usually add something like the following at the bottom of the commit log:

Changes from patch 1 to 2:
   -Fixed whitespace issues
   ....

Also, you're still missing the new 
ConsoleRedirectionServiceCapabilities.h header file you created.  You 
can add it to the patch using "hg add 
ConsoleRedirectionServiceCapabilities.h" and then "hg qref".

Thanks!
-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com