[Libvirt-cim] [PATCH 2 of 5] [TEST] Create a disk pool before running any tests

[Deepti B Kalakeri]

Kaitlin Rupert wrote:
>>>
>>> +    status, dpool = create_diskpool_conf(ip, virt, 
>>> dpool=default_pool_name)
>>> +    if status != PASS:
>>> +        print "\nUnable to create disk pool %s" % default_pool_name
>>> +        status = destroy_netpool(ip, virt, default_network_name)
>>> +        if status != PASS:
>>> +            print "\nUnable to destroy network pool %s." % 
>>> default_network_name +        return FAIL
>>>   
>> The test wont proceed if the cimtest-diskpool already exist on the 
>> machine, unless we manually delete the same.
>
> Yes, that's the intended behavior here.  The test suite prints out a 
> message to the user that a diskpool with the name name already exists. 
> The user will need to remove the pool manually or rename the pool.
>
> Instead of attempting to guess a poolname that is not in use, we 
> require a specific name to be available.  I think it is reasonable 
> because the name we are attempting to use is fairly unique.  Also, if 
> the test suite is unable to clean up pools properly, the system 
> becomes littered with tons of pools the suite has generated.
>
> I'd rather use known, specific name for the test suite.  If the pool 
> already exists, the user can then modify their environment so that the 
> test suite can run.
>
> Does this seem reasonable?
I agree with the above. Sounds valid.
Thanks and Regards,
Deepti.
>
>