[Libvirt-cim] [PATCH] Eliminate error status on EAFP when no pool link exists

Dan Smith danms at us.ibm.com
Wed Sep 10 16:27:41 UTC 2008


# HG changeset patch
# User Dan Smith <danms at us.ibm.com>
# Date 1221064059 25200
# Node ID 6a8e14dc94847ac449a65a28f83e6f8ee2b22fbd
# Parent  5d114b296a8228d1e591e1908fbecd4a96152e5e
Eliminate error status on EAFP when no pool link exists

I think that the proper behavior is to just not return anything instead of an
error.  Since not being affiliated with a pool isn't necessarily an error, we
shouldn't kill an entire associaton operation as a result.

Signed-off-by: Dan Smith <danms at us.ibm.com>

diff -r 5d114b296a82 -r 6a8e14dc9484 src/Virt_ElementAllocatedFromPool.c
--- a/src/Virt_ElementAllocatedFromPool.c	Wed Sep 10 09:27:19 2008 -0700
+++ b/src/Virt_ElementAllocatedFromPool.c	Wed Sep 10 09:27:39 2008 -0700
@@ -75,9 +75,7 @@
 
         poolid = pool_member_of(_BROKER, CLASSNAME(ref), type, id);
         if (poolid == NULL) {
-                cu_statusf(_BROKER, &s,
-                           CMPI_RC_ERR_FAILED,
-                           "Unknown pool membership for `%s'", id);
+                CU_DEBUG("No pool membership for `%s'", id);
                 goto out;
         }
 




More information about the Libvirt-cim mailing list