[Libvirt-cim] [PATCH] [TEST] Add test for verifying disabled RequestStateChange()

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Tue Aug 11 22:03:30 UTC 2009


>> +# information is captured in the RequestedState Property of the VS.
>> +# The test is considered to be successful if RequestedState Property
>> +# has a value of 3 when the VS is moved from active state to a 
>> disabled state.
>>   
> The test case does not verify the value if EnabledState is set to 3.
> Did you miss adding it ?

No, it should. I forgot this.  Plus, this comment isn't totally 
accurate, because the behavior will be different depending on the 
provider version.

>> +#
>> +# Date: 08-07-2009
>> +
>> +import sys
>> +from CimTest.Globals import logger
>> +from XenKvmLib.const import do_main
>> +from CimTest.ReturnCodes import PASS, FAIL, XFAIL_RC
>>   
> XFAIL_RC is not needed

Good call.


>> +
>> +    cxml.cim_destroy(server)
>>   
> We do not require cim_destroy if cim_disable is successful.

With the older versions of the providers, we do. Because with the other 
versions. disable is mapped to a reboot.

>> +    cxml.undefine(server)
>> +



-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list