[Libvirt-cim] [PATCH 2 of 2] Adds state information to the instance created in ComputerSystemDeletedIndication

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Thu Aug 27 21:29:59 UTC 2009


> @@ -463,7 +399,7 @@
>          if (!set_capdesc_from_dominfo(broker, dominfo, ref, instance)) {
>                  CU_DEBUG("Problem in set_capdesc_from_dominfo function");
>                  cu_statusf(broker, &s, 
> -                           CMPI_RC_FAILED, 
> +                           CMPI_RC_ERR_FAILED, 

Oh, I hadn't looked at this patch yet when I reviewed the first one. 
Instead of making the changes in this patch.. just make these changes in 
the first one.  No need to have your second patch fix errors in the 
first patch.

>                             "Could not set caption and description properties");
>                  goto out;
>          }
> @@ -474,7 +410,7 @@
>          if (!set_creation_class(instance)) {
>                  CU_DEBUG("Problem in set_creation_class function");
>                  cu_statusf(broker, &s,
> -                           CMPI_RC_FAILED,
> +                           CMPI_RC_ERR_FAILED,
>                             "Could not set creation class");
>                  goto out;
>          }
> @@ -482,7 +418,7 @@
>          if (!set_other_id_info(broker, dominfo->uuid, prefix, instance)) {
>                  CU_DEBUG("Problem in set_other_id_info function");
>                  cu_statusf(broker, &s,
> -                           CMPI_RC_FAILED,
> +                           CMPI_RC_ERR_FAILED,
>                             "Could not set other OtherIdentifyingInfo and "
>                             "IdentifyingDescription");
>                  goto out;

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list