[Libvirt-cim] [PATCH 0 of 2] Camel case to lower case variable name change.

[Sharad Mishra]

Kaitlin,

      But when cimtest's vxml.py calls DefineSystem -

###########
            service.DefineSystem(SystemSettings=sys_settings,
                                 ResourceSettings=res_settings,
                                 ReferenceConfiguration=ref_conf)
#############


      it passes "res_settings" and these were set in vsms.py as -

************
class CIM_GraphicsResourceAllocationSettingData(CIMClassMOF):
    def __init__(self, name, res_sub_type="vnc", ip=None, ipv6_flag=None,
                 lport='-1', keymap="en-us", vnc_passwd=None):
        self.InstanceID = '%s/graphics' %name
        self.ResourceType = RASD_TYPE_GRAPHICS

        if res_sub_type != None:
            self.ResourceSubType = res_sub_type

        if ip != None and lport != None:
           self.Address = '%s:%s' % (ip, lport)

        if ipv6_flag != None::%
           self.is_ipv6_only = ipv6_flag
*************

So the name should change in VSMS.c too.

Sharad Mishra
System x Enablement
Linux Technology Center
IBM:

libvirt-cim-bounces at redhat.com wrote on 12/03/2009 04:48:31 PM:

> Kaitlin Rupert <kaitlin at linux.vnet.ibm.com>
> Sent by: libvirt-cim-bounces at redhat.com
>
> 12/03/2009 04:48 PM
>
> Please respond to
> List for discussion and development of libvirt CIM
<libvirt-cim at redhat.com>
>
> To
>
> List for discussion and development of libvirt CIM
<libvirt-cim at redhat.com>
>
> cc
>
> Subject
>
> Re: [Libvirt-cim] [PATCH 0 of 2] Camel case to lower case variable
> name change.
>
> I don't think these changes are necessary.  IsIPv6Only fits the DMTF's
> naming convention for attributes.  I would say to leave the attribute
> name as is.
>
> Sharad Mishra wrote:
> > Signed-off-by: Sharad Mishra <snmishra at us.ibm.com>
> >
> > _______________________________________________
> > Libvirt-cim mailing list
> > Libvirt-cim at redhat.com
> > https://www.redhat.com/mailman/listinfo/libvirt-cim
>
>
> --
> Kaitlin Rupert
> IBM Linux Technology Center
> kaitlin at linux.vnet.ibm.com
>
> _______________________________________________
> Libvirt-cim mailing list
> Libvirt-cim at redhat.com
> https://www.redhat.com/mailman/listinfo/libvirt-cim
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvirt-cim/attachments/20091203/eb37a35d/attachment.htm>