[Libvirt-cim] [PATCH 1 of 2] [TEST] Created testcases for the forward HostedAccessPoint association (HostSystem -> KVMRedirectionSAP

Kaitlin Rupert kaitlin at linux.vnet.ibm.com
Tue Feb 10 15:26:33 UTC 2009


>>> +                kvmrsap_inst = kvmrsap
>>> +
>>> +    except Exception, details:
>>> +        logger.error(details)
>>> +        return kvmrsap_inst, FAIL
>>> +
>>> +    return kvmrsap_inst, PASS
>>> +
>>> +def verify_kvmrsap(enum_list, kvmrsap_inst): +    status = FAIL
>>> +
>>> +    for item in enum_list:
>>
>> You should get get only one KVMRedirectionSAP.  Verify enum_list only 
>> has one element.  If it has more than one, return an error.
>>
>> Remove the for loop - since there's only one element in the list, no 
>> need to use a loop here.
> 
> I don't get it. When I execute the ServiceAccessBySAP query 
> (ConsoleRedirectionService -> KVMRedirectionSAP) I receive one item per 
> virtual machine configured in the host. The same happens when I do the 
> query using pywbem

Oh,yes - you're right.  The structure of the test case threw me off 
some.  Let me send an updated review, because I misunderstood what you 
were trying to verify.

-- 
Kaitlin Rupert
IBM Linux Technology Center
kaitlin at linux.vnet.ibm.com




More information about the Libvirt-cim mailing list